Merged
Conversation
yebai
reviewed
Jun 20, 2025
| AutoGTPSA, | ||
| AutoModelingToolkit, | ||
| AutoMooncake, | ||
| AutoMooncakeForward, |
There was a problem hiding this comment.
For completeness, I suggest we consider introducing AutoMooncakeBackward, then alias AutoMooncake = AutoMooncakeBackward.
Collaborator
Author
There was a problem hiding this comment.
I think having two names for the same thing introduces unneeded confusion. We can remove AutoMooncakeForward at the next breaking release of ADTypes if there ever is one
ChrisRackauckas
approved these changes
Aug 13, 2025
Member
ChrisRackauckas
left a comment
ChrisRackauckas
left a comment
There was a problem hiding this comment.
Reasonable enough to me.
Member
|
Though I'd be willing to do that breaking change "soon" so that it's before Mooncake adoption is big. |
Collaborator
Author
|
It seems TagBot didn't work, although the new version was registered? |
Member
|
Maybe it just takes a bit longer? Or do you see a failed run? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This PR adds the
AutoMooncakeForwardtype, in anticipation of chalk-lab/Mooncake.jl#389 landing. It is different from the existingAutoMooncakebecause otherwise we would have had to replacemode(::AutoMooncake) = ForwardMode()withmode(::AutoMooncake) = ForwardOrReverseMode(), which can be considered breaking.cc @willtebbutt