Skip to content

Conversation

phwissmann
Copy link

@phwissmann phwissmann commented Sep 17, 2025

Typo in selected callback method

Description

Short description of the pull request

Motivation

Background on use case, changes needed

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Bug Fixes:

  • Correct the logout button click handler to call openIngestorLogout() instead of openIngestorLogin()

Typo in selected callback method
@Junjiequan
Copy link
Member

Good catch. Is it ready for review or?

@sofyalaski sofyalaski self-requested a review September 17, 2025 13:33
@sofyalaski
Copy link
Member

Hey @Junjiequan, this pr is for PSI specific fork, and I will include a necessary change in another PR that I am preparing. It will contain that whole ingestor component, so you will be very welcome to review that later :)

@Junjiequan
Copy link
Member

Hey @Junjiequan, this pr is for PSI specific fork, and I will include a necessary change in another PR that I am preparing. It will contain that whole ingestor component, so you will be very welcome to review that later :)

Ahh, I see now.
I thought the typo was from the existing code😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants