Update frontend to match with release-jobs backend #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sbliven
approved these changes
Sep 16, 2024
| fileList.push(d["archiveId"]); | ||
| }); | ||
| } | ||
| fileObj.files = fileList; |
There was a problem hiding this comment.
We should discuss this change with some site that used the files property.
sbliven
added a commit
to sbliven/scicat-frontend
that referenced
this pull request
Dec 17, 2024
This commit rebases and squashes SciCatProject#1585 (7d2a872). It contains the following commits: - update job view to match release-jobs - update job schema and timestamp fields - update jobs-detail page - fix testing and linting
sofyalaski
pushed a commit
to sofyalaski/frontend
that referenced
this pull request
Dec 17, 2024
* update job view to match release-jobs * update job schema and timestamp fields * update jobs-detail page * fix testing and linting
sofyalaski
pushed a commit
to sofyalaski/frontend
that referenced
this pull request
Dec 17, 2024
* update job view to match release-jobs * update job schema and timestamp fields * update jobs-detail page * fix testing and linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make a first try to see whether the MVP
release-jobsbackend is compatible with the frontend.Description
To make the frontend compatible with the new Jobs schema from the
release-jobsbackend, we have to update the job list page, the job detail page, the schema in the frontend and all its references to it, as well as the.spectest files.Fixes:
Changes:
src/app/shared/sdk/models/Job.tsby updating the definition ofJobclassJobclass is created:datasetIdsinsidejobParamsemailJobInitiatortocreatedByand its value should beusernameinstead ofemailcreationTimetocreatedAtjobs-dashboard-new.componentandjobs-detail.component, so show in the job list and job details pages the new fields of the Job classjobs-dashboard.componenthad to be updated too to avoid getting errors, but it appears to no longer be usedJobclass is created in one of the test filesBackend version
release-jobs