Feature/fixing camera problems #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soracel
requested review from
smallTrogdor
and removed request for
smallTrogdor
…nner-flutter into feature/fixing-camera-problems # Conflicts: # example/android/app/build.gradle # example/pubspec.yaml # pubspec.yaml
smallTrogdor
requested changes
Sep 29, 2025
Collaborator
smallTrogdor
left a comment
smallTrogdor
left a comment
There was a problem hiding this comment.
Nice - I left some remarks, especially about the Changelog. Otherwise just nitpicks
example/android/app/build.gradle
Outdated
|
|
||
| defaultConfig { | ||
| applicationId "ch.sbb.datascanner.example" | ||
| minSdkVersion 21 |
Collaborator
There was a problem hiding this comment.
probably easier to leave at Flutter.minSDKVersion ...
example/android/app/build.gradle
Outdated
| } | ||
|
|
||
| compileOptions { | ||
| sourceCompatibility JavaVersion.VERSION_11 |
chore: update flutter version to 3.35.0 refactor: nitpicks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added a workaround to convert images to the NV21 format, since ML Kit currently does not support other formats.
This workaround should be removed once flutter/packages#10022 is merged.
Fixes
Checklist
Before creating a PR, run through this checklist and mark each as complete:
CONTRIBUTINGdocument