Include feature for (native) certificates #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses Schniz#314 allowing use of fnm when behind a proxy with certificates. This adds the `"rustls-tls-native-roots"` [cargo feature](https://docs.rs/reqwest/0.11.3/reqwest/#optional-features) to reqwest. That uses [rustls-native-certs](https://github.com/rustls/rustls-native-certs): > rustls-native-certs allows rustls to use the platform's native certificate store when operating as a TLS client. I tested on macOS both with and without proxy mainly doing `cargo run -- list-remote`, and installing node 16, this worked behind proxy. Without proxy I only tested list-remote. Perhaps other commands need to be retested as well. The [`native-tls`](https://docs.rs/native-tls/0.2.7/native_tls/) feature might also work, I didn't test. They seem to cover similar functionality but maybe it works better on Linux ARM systems.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/schniz/fnm/JBg5z97WAnFE73QrGWA4nJNadGoQ |
|
Awesome! Thanks. Let's see if all e2e tests pass 🙏 |
itotallyrock
pushed a commit
to itotallyrock/fnm
that referenced
this pull request
Aug 10, 2021
Schniz
pushed a commit
that referenced
this pull request
Aug 15, 2021
Co-authored-by: Jeffrey Meyer <[email protected]>
pfiaux
added a commit
to pfiaux/fnm
that referenced
this pull request
Dec 16, 2021
Addresses Schniz#314 allowing use of fnm when behind a proxy with certificates by reapplying Schniz#468 after the revert from ureq to reqwest. This adds the `"rustls-tls-native-roots"` [cargo feature](https://docs.rs/reqwest/0.11.3/reqwest/#optional-features) to reqwest. That uses [rustls-native-certs](https://github.com/rustls/rustls-native-certs): > rustls-native-certs allows rustls to use the platform's native certificate store when operating as a TLS client. I tested on macOS both with and without proxy mainly doing `cargo run -- list-remote`, and installing node 16, this worked behind proxy. Without proxy I only tested list-remote. Perhaps other commands need to be retested as well. The [`native-tls`](https://docs.rs/native-tls/0.2.7/native_tls/) feature might also work, I didn't test. They seem to cover similar functionality but maybe it works better on Linux ARM systems.
Schniz
pushed a commit
that referenced
this pull request
Dec 28, 2021
Addresses #314 allowing use of fnm when behind a proxy with certificates by reapplying #468 after the revert from ureq to reqwest. This adds the `"rustls-tls-native-roots"` [cargo feature](https://docs.rs/reqwest/0.11.3/reqwest/#optional-features) to reqwest. That uses [rustls-native-certs](https://github.com/rustls/rustls-native-certs): > rustls-native-certs allows rustls to use the platform's native certificate store when operating as a TLS client. I tested on macOS both with and without proxy mainly doing `cargo run -- list-remote`, and installing node 16, this worked behind proxy. Without proxy I only tested list-remote. Perhaps other commands need to be retested as well. The [`native-tls`](https://docs.rs/native-tls/0.2.7/native_tls/) feature might also work, I didn't test. They seem to cover similar functionality but maybe it works better on Linux ARM systems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #314 allowing use of fnm when behind a proxy with certificates.
This adds the
"rustls-tls-native-roots"cargo feature to reqwest. That uses rustls-native-certs:I tested on macOS both with and without proxy mainly doing
cargo run -- list-remote, and installing node 16, this worked behind proxy. Without proxy I only tested list-remote. Perhaps other commands need to be retested as well.The
native-tlsfeature might also work, I didn't test. They seem to cover similar functionality but maybe it works better on Linux ARM systems.