Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scoop support #329

Merged
merged 2 commits into from
Nov 24, 2020
Merged

Add scoop support #329

merged 2 commits into from
Nov 24, 2020

Conversation

Armaldio
Copy link
Contributor

@Armaldio Armaldio commented Nov 10, 2020 •
edited
Loading

Hey 👋

I have an open PR for fnm on scoop.
Keeping this as draft until merged.

Feel free to write better Readme if the current changes doesn't fit 🙂

@vercel
Copy link

vercel bot commented Nov 10, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/schniz/fnm/gw04har2n
✅ Preview: https://fnm-git-patch-1.schniz.vercel.app

@Schniz Schniz added the PR: Documentation Some docs were added label Nov 15, 2020
@Schniz
Copy link
Owner

Schniz commented Nov 15, 2020

Exciting!

@Armaldio Armaldio marked this pull request as ready for review November 20, 2020 07:11
@Armaldio
Copy link
Contributor Author

PR was merged 🎉

@Schniz
Copy link
Owner

Schniz commented Nov 24, 2020

Can we move the entire block to "manual" (like Homebrew is for OSX)? The "with script" heading is for using an installation script which also installs the fnm env to your shell. Then, we can think on how to make the installation script work on Windows as well (it is currently a Bash script)

Thanks again!

@Armaldio
Copy link
Contributor Author

Like this ?

Schniz
Schniz approved these changes Nov 24, 2020
View reviewed changes
Copy link
Owner

@Schniz Schniz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! amazing!

@Schniz Schniz merged commit d365502 into Schniz:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schniz Schniz Schniz approved these changes

Assignees
No one assigned
Labels
PR: Documentation Some docs were added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Armaldio @Schniz