Arc/msc3971 #15
Open
Arc/msc3971 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewRyanChama
force-pushed
the
arc/msc3971
branch
from
dbee1b6
to
c1b54b6
Compare
|
Could you try to fix at least the newly introduced linting issues? |
AndrewRyanChama
force-pushed
the
arc/msc3971
branch
3 times, most recently
from
00cc499
to
a9b950c
Compare
|
@su-ex lint should be fixed now |
|
Seems there are still some linting issues. |
AndrewRyanChama
force-pushed
the
arc/msc3971
branch
from
a9b950c
to
6386631
Compare
AndrewRyanChama
force-pushed
the
arc/msc3971
branch
4 times, most recently
from
8c7e179
to
50b10a6
Compare
make them clickable fix typescript error checks
AndrewRyanChama
force-pushed
the
arc/msc3971
branch
from
50b10a6
to
270b085
Compare
|
@su-ex can you take a look again now? I'm pretty sure I can'tfix the other failed checks without changing a whole bunch of stuff all over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fresh delivery for matrix-org/matrix-spec-proposals#3971
Does the following:
This doesn't implement any advanced UI for after clicking the link, but does send the user to the correct room. A future change will be to show the user a big red button to add the pack.