Skip to content

Fix grammar in 2 strings in strings.xml#125

Closed
jtbx wants to merge 1 commit into
SchildiChat:scfrom
jtbx:sc
Closed

Fix grammar in 2 strings in strings.xml#125
jtbx wants to merge 1 commit into
SchildiChat:scfrom
jtbx:sc

Conversation

@jtbx
Copy link
Copy Markdown

@jtbx jtbx commented May 24, 2022

Line 1580 of /vector/src/main/res/values/strings.xml reads

<string name="room_list_people_empty_body">Your direct message conversations will be displayed here. Tap the + bottom right to start some.</string>

Tap the + bottom right to start some is a grammar mistake, so I changed it to Tap the + at the bottom right to start some instead.

In line 1582 it says something similar, so I corrected that as well.

This error is also part of upstream Element code.

Edit: Upstream PR is element-hq#6132

@jtbx jtbx changed the title Fix grammar in strings.xml Fix grammar in a string in strings.xml May 24, 2022
@jtbx jtbx changed the title Fix grammar in a string in strings.xml Fix grammar in 2 strings in strings.xml May 24, 2022
@SpiritCroc
Copy link
Copy Markdown
Member

SpiritCroc commented May 24, 2022

Hi, thanks for creating this PR. Merging such upstream string changes into SchildiChat would not help for long though:
We don't change upstream strings manually to avoid merge conflicts. So if we want to have different strings then upstream, we automate this in correct_strings.sh. But for this one, it's better to just wait for upstream to merge the fix, then we'll get it with the next upstream merge.

@jtbx
Copy link
Copy Markdown
Author

jtbx commented May 24, 2022

Okay, thanks. I'll leave the Element PR to be merged.

@jtbx jtbx closed this May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants