Skip to content

[claude-code-settings] Add missing tool names to permissionRule pattern #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Feb 11, 2026
Merged

[claude-code-settings] Add missing tool names to permissionRule pattern #5363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions src/schemas/json/claude-code-settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"permissionRule": {
"type": "string",
"description": "Tool permission rule. See https://code.claude.com/docs/en/settings#permission-rule-syntax",
"pattern": "^((Bash|Edit|ExitPlanMode|Glob|Grep|KillShell|LS|MultiEdit|NotebookEdit|NotebookRead|Read|Skill|Task|TaskOutput|TodoWrite|WebFetch|WebSearch|Write)(\\((?=.*[^)*?])[^)]+\\))?|mcp__.*)$",
"pattern": "^((Bash|Edit|ExitPlanMode|Glob|Grep|KillShell|LS|LSP|MultiEdit|NotebookEdit|NotebookRead|Read|Skill|Task|TaskCreate|TaskGet|TaskList|TaskOutput|TaskStop|TaskUpdate|TodoWrite|ToolSearch|WebFetch|WebSearch|Write)(\\((?=.*[^)*?])[^)]+\\))?|mcp__.*)$",
"examples": [
"Bash",
"Bash(npm run build)",
Expand Down Expand Up @@ -482,20 +482,6 @@
"items": {
"$ref": "#/$defs/hookMatcher"
}
},
"TeammateIdle": {
"type": "array",
"description": "Hooks that run when a teammate agent is about to go idle. Exit code 2 sends feedback and keeps the teammate working.",
"items": {
"$ref": "#/$defs/hookMatcher"
}
},
"TaskCompleted": {
"type": "array",
"description": "Hooks that run when a task is being marked as completed. Exit code 2 prevents completion with feedback.",
"items": {
"$ref": "#/$defs/hookMatcher"
}
}
}
},
Expand Down
20 changes: 0 additions & 20 deletions src/test/claude-code-settings/hooks-complete.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,26 +160,6 @@
]
}
],
"TaskCompleted": [
{
"hooks": [
{
"command": "echo 'Task completed' >> /tmp/claude-teams.log",
"type": "command"
}
]
}
],
"TeammateIdle": [
{
"hooks": [
{
"command": "echo 'Teammate going idle' >> /tmp/claude-teams.log",
"type": "command"
}
]
}
],
"UserPromptSubmit": [
{
"hooks": [
Expand Down
2 changes: 2 additions & 0 deletions src/test/claude-code-settings/permissions-advanced.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
"Grep",
"Read(~/projects/**)",
"Edit(~/projects/**)",
"ToolSearch",
"LSP",
"NotebookEdit",
"TodoWrite",
"WebFetch(domain:github.com)",
Expand Down