-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Update Claude Code settings schema for v2.1.29 with hostPattern/async and test coverage #5332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
src/negative_test/claude-code-settings/invalid-marketplace-host-pattern.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "extraKnownMarketplaces": { | ||
| "internal-git": { | ||
| "source": { | ||
| "source": "hostPattern" | ||
| } | ||
| } | ||
| }, | ||
| "strictKnownMarketplaces": [ | ||
| { | ||
| "hostPattern": 123, | ||
| "source": "hostPattern" | ||
| } | ||
| ] | ||
| } |
19 changes: 19 additions & 0 deletions
19
src/negative_test/claude-code-settings/wrong-property-types.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,29 @@ | ||
| { | ||
| "cleanupPeriodDays": "thirty", | ||
| "enableAllProjectMcpServers": 1, | ||
| "hooks": { | ||
| "PreToolUse": [ | ||
| { | ||
| "hooks": [ | ||
| { | ||
| "async": "true", | ||
| "command": "echo test", | ||
| "type": "command" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| "includeCoAuthoredBy": "yes", | ||
| "permissions": { | ||
| "additionalDirectories": "should be array", | ||
| "allow": "should be array", | ||
| "ask": "should be array" | ||
| }, | ||
| "sandbox": { | ||
| "network": { | ||
| "allowAllUnixSockets": "yes", | ||
| "allowedDomains": "api.anthropic.com" | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/test/claude-code-settings/marketplace-host-pattern.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "extraKnownMarketplaces": { | ||
| "internal-git": { | ||
| "source": { | ||
| "hostPattern": "git.internal.example.com", | ||
| "source": "hostPattern" | ||
| } | ||
| } | ||
| }, | ||
| "strictKnownMarketplaces": [ | ||
| { | ||
| "hostPattern": "*.corp.example", | ||
| "source": "hostPattern" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kanghyojun @hyperupcall @domdomegg I had removed
SlashCommandfrom this regex in #5300 . As per my understanding, after the new behavior of treating commands as skills,SlashCommandtool permission requests are not going to be sought.The only reason to retain it could be to cover the use case of someone consciously using much older versions, which still used the
SlashCommandtool. However, it's been a long time since the change fromSlashCommandtoSkill. So I am wondering whether there is merit to retain it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Miteshashar is right —
SlashCommandwas renamed toSkillas a tool name back in October 2025. ASlashCommand(...)permission rule would be silently ignored since no tool has that name anymore. Fine to drop it.