Update all contributors schema #3853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
commitTypeproperty, which is added by the all contributors bot. There is a PR to add documentation to the all contributors project hereRemove the enum fromcontributionsas it is possible to create custom contribution types.Valid files with custom contribution types would fail validation using the existing schema.
I'm not certain it isn't possible but I couldn't find a way to make a list of valid contribution types, which would be the union of the built in types and any types defined in
types.You cannot know all of the valid values before reading the
allcontributorsrcfile.Use
anyOfto so that valid contribution types are either from the list of default contribution types or a string, allowing for custom contributions.Perhaps a little redundant as the string option is so permissive.