Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions workflows multiple "OneOf" is true #2465

Merged
merged 2 commits into from
Sep 5, 2022
Merged

GH Actions workflows multiple "OneOf" is true #2465

merged 2 commits into from
Sep 5, 2022

Conversation

GerryFerdinandus
Copy link
Contributor

"OneOf" cannot have more than one true item. The problem is due to wrong use of "$ref"
This is for issue #2463

two items in OneOff is true. thats is why IntelliJ give error.
"$ref": "..." must be without other keyword in draft 04..07
@GerryFerdinandus GerryFerdinandus merged commit 690f433 into SchemaStore:master Sep 5, 2022
@GerryFerdinandus GerryFerdinandus deleted the pr_github_action branch September 5, 2022 18:34
jmatias pushed a commit to jmatias/schemastore that referenced this pull request Sep 20, 2022
* fix issue SchemaStore#2463 GH Actions workflows

two items in OneOff is true. thats is why IntelliJ give error.
"$ref": "..." must be without other keyword in draft 04..07

* add test file mentioned in issue SchemaStore#2463
@ssbarnea
Copy link
Contributor

ssbarnea commented Oct 5, 2022

This change adds a critical regression to the schema, one that prevents the use of expansions inside vars, as now only simple strings would be allowed.

Even the example from https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-10 would no longer pass.

I guess that #2510 will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants