Add simple object storage package for s3 and swift #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsudaar
reviewed
Jul 23, 2019
storage/s3.go
Outdated
| s3config := s3Config(cfg) | ||
| return &S3{ | ||
| cfg: cfg, s3client: s3.New(s3config), s3uploader: s3manager.NewUploader(s3config), | ||
| retryWaitDuration: time.Second, retryAttempts: 3, |
There was a problem hiding this comment.
Shouldn't those two fields be configurable ?
There was a problem hiding this comment.
Actually after thinking I'm wondering if it's not the package use who should be responsible of retrying a Size() command (waiting for eventual consistency right after an upload) What do you think?
There was a problem hiding this comment.
mmmh if the service is eventually consistent i find it pretty nice that the package offer this option. Otherwise it should be configurable.
Ok will do |
|
mock added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.