Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation errors builder string #109

Merged
merged 4 commits into from
Mar 19, 2020
Merged

Fix validation errors builder string #109

merged 4 commits into from
Mar 19, 2020

Conversation

brandon-welsch
Copy link
Member

Close #108

EtienneM
EtienneM requested changes Mar 19, 2020
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you write a test to match the situation you just fixed?

EtienneM
EtienneM approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great tests

@EtienneM EtienneM merged commit 784f1d7 into master Mar 19, 2020
@EtienneM EtienneM deleted the fix/108/validation_errors_builder_string branch March 19, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValidationErrors Builder returns a string that is not very readable
2 participants
@brandon-welsch @EtienneM