refactor(otel): Remove wrapping of OTEL sdk and release the otel package #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-welsch
changed the title
SCKevinO
reviewed
Feb 12, 2025
otel/otel_test.go
Outdated
| // Check that pointer are the same | ||
| assert.Equal(t, previousGlobalProviders, *globalProviders) | ||
| } | ||
| require.NotNil(t, otelsdk.GetMeterProvider()) |
There was a problem hiding this comment.
otelsdk.GetMeterProvider() will never return nil. If the meter provider has not been registered, it returns a no-op implementation
There was a problem hiding this comment.
Yes, so i will remove that
brandon-welsch
force-pushed
the
feat/1084/first-version-of-otel-package
branch
from
e471d2d to
c101658
Compare
brandon-welsch
force-pushed
the
feat/1084/first-version-of-otel-package
branch
from
c101658 to
8e8a310
Compare
SCKevinO
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1084
This will contain the latest changes we done on the package. With the first release of the package
CHANGELOG.md