Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(one-off): remove async field from the run command #390

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix(one-off): remove async field from the run command #390

merged 2 commits into from
Aug 20, 2024

Conversation

SCedricThomas
Copy link
Contributor

@SCedricThomas SCedricThomas self-assigned this Aug 20, 2024
@SCedricThomas SCedricThomas changed the title feat: add a CHANGELOG entry feat(run): remove async field Aug 20, 2024
@SCedricThomas SCedricThomas changed the title feat(run): remove async field fix(one-off): remove async field from the run command Aug 20, 2024
@SCedricThomas
Copy link
Contributor Author

Will be merged once the QA is done

@SCedricThomas SCedricThomas marked this pull request as ready for review August 20, 2024 14:04
ipfaze
ipfaze approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ipfaze ipfaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SCedricThomas SCedricThomas merged commit 98ad369 into master Aug 20, 2024
2 checks passed
@SCedricThomas SCedricThomas deleted the fix/remove-async-one-off branch August 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipfaze ipfaze ipfaze approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCedricThomas @ipfaze