Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change maintenance listing pagination meta to standard pagination meta #352

Merged
merged 5 commits into from
Jul 18, 2023
Merged

Change maintenance listing pagination meta to standard pagination meta #352

merged 5 commits into from
Jul 18, 2023

Conversation

SCedricThomas
Copy link
Contributor

@SCedricThomas SCedricThomas commented Jul 17, 2023 •
edited
Loading

fix #351

@SCedricThomas SCedricThomas self-assigned this Jul 17, 2023
@SCedricThomas SCedricThomas marked this pull request as draft July 17, 2023 14:14
@SCedricThomas SCedricThomas marked this pull request as ready for review July 17, 2023 14:33
curzolapierre
curzolapierre reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: We should not abbreviate struct

maintenance.go Outdated Show resolved Hide resolved
maintenance.go Outdated Show resolved Hide resolved
SCedricThomas and others added 2 commits July 18, 2023 15:34
@SCedricThomas @curzolapierre
Update maintenance.go
a16f07b 
Co-authored-by: Pierre Curzola <[email protected]>
@SCedricThomas @curzolapierre
Update maintenance.go
19f02e8 
Co-authored-by: Pierre Curzola <[email protected]>
@SCedricThomas SCedricThomas merged commit 5a29d3a into master Jul 18, 2023
@SCedricThomas SCedricThomas deleted the fix/351/maintenance-listing-prototype branch July 18, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curzolapierre curzolapierre curzolapierre approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance listing doesn't respect the pagination prototypes
2 participants
@SCedricThomas @curzolapierre