Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance listing #344

Merged
merged 8 commits into from
Jul 7, 2023
Merged

Maintenance listing #344

merged 8 commits into from
Jul 7, 2023

Conversation

SCedricThomas
Copy link
Contributor

fix #340

@SCedricThomas SCedricThomas self-assigned this Jun 2, 2023
@SCedricThomas SCedricThomas marked this pull request as ready for review July 4, 2023 12:38
curzolapierre
curzolapierre previously approved these changes Jul 4, 2023
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo, otherwise LGTM

maintenance.go Show resolved Hide resolved
@SCedricThomas SCedricThomas merged commit 631ba96 into master Jul 7, 2023
@SCedricThomas SCedricThomas deleted the feat/340/maintenance-listing branch July 7, 2023 14:04
var maintenanceRes ListMaintenanceResponse
err := c.DBAPI(app, addonID).SubresourceList(ctx, "databases", addonID, "maintenance", opts.ToMap(), &maintenanceRes)
if err != nil {
return ListMaintenanceResponse{}, errgo.Notef(err, "list database '%v' maintenance", addonID)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the DatabaseListMaintenance function does not follow other function prototype with pagination.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will tackle this issue as soon as possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but is the API available? It seems to returns 404 for now (trying to add the steampipe tables).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place for this kind of question, you should instead address your question to our support team through intercom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance listing
3 participants