Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query data of a single pull request #335

Merged
merged 4 commits into from
May 4, 2023
Merged

Conversation

yohann-bacha
Copy link
Contributor

@yohann-bacha yohann-bacha commented Apr 28, 2023

Fixes #327

@yohann-bacha yohann-bacha self-assigned this Apr 28, 2023
@@ -97,6 +99,20 @@ type SCMRepoLinkReviewAppsResponse struct {
ReviewApps []*ReviewApp `json:"review_apps"`
}

type SCMRepoLinkPullRequestResponse struct {
Pull RepoLinkPullRequest `json:"pull"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I know it's not related to this pull request, but why does the API only returns pull and not pull_request?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, as the /pulls endpoint returns a pulls attribute, and not pull_requests, I went for pull!

scm_repo_link.go Outdated Show resolved Hide resolved
Co-authored-by: Étienne M. <[email protected]>
@yohann-bacha yohann-bacha requested a review from EtienneM May 3, 2023 08:44
EtienneM
EtienneM previously approved these changes May 3, 2023
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to fix, otherwise LGTM

scm_repo_link.go Outdated Show resolved Hide resolved
@yohann-bacha yohann-bacha merged commit 78a81b3 into master May 4, 2023
@yohann-bacha yohann-bacha deleted the feat/327/pr branch May 4, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bind querying a PR/MR data
2 participants