-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: query data of a single pull request #335
Conversation
@@ -97,6 +99,20 @@ type SCMRepoLinkReviewAppsResponse struct { | |||
ReviewApps []*ReviewApp `json:"review_apps"` | |||
} | |||
|
|||
type SCMRepoLinkPullRequestResponse struct { | |||
Pull RepoLinkPullRequest `json:"pull"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: I know it's not related to this pull request, but why does the API only returns pull
and not pull_request
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, as the /pulls
endpoint returns a pulls
attribute, and not pull_requests
, I went for pull
!
Co-authored-by: Étienne M. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment to fix, otherwise LGTM
Fixes #327