feat(sdk): introduce a Manifest type
#60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
force-pushed
the
feat/STORY-270/manifest_implements
branch
2 times, most recently
from
f23d50e to
df8da5d
Compare
EtienneM
force-pushed
the
feat/STORY-270/manifest_implements
branch
from
df8da5d to
ea1196a
Compare
sc-zenokerr
approved these changes
Feb 13, 2025
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## To Be Released | |||
|
|
|||
| * feat(sdk): introduce a `Manifest` type | |||
There was a problem hiding this comment.
Would it make sense add a note here, highlighting that this would require a major version bump?
There was a problem hiding this comment.
I will handle the major version now, so I don't think it's required. I will remember to do it :)
|
|
||
| manifest = `{"Implements": ["` + AuthZApiImplements + `"]}` |
Yes they have been tested in https://github.com/Scalingo/swan-agent/pull/293/commits/bce7b817405d8a21949195a6d4e01892be15dd25 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we need to pass a string and I find this ugly. For example:
This is too error-prone in my opinion.
Introduction of this PR would lead to a new major version (v2). This lib is only used in SAND and SWAN. If we don't upgrade to v2 in SAND, then there is no impact there. And we just need to use this version in SWAN.
Related to STORY-270