build: match Scalingo best practice #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
force-pushed
the
deps/go_dependencies
branch
8 times, most recently
from
b470a39 to
483bb95
Compare
EtienneM
commented
Feb 11, 2025
| "github.com/docker/go-plugins-helpers/sdk" | ||
| "github.com/sirupsen/logrus" | ||
|
|
||
| "github.com/Scalingo/go-plugins-helpers/sdk" |
There was a problem hiding this comment.
This change is needed so that the specs use the function createPluginSpecDirUnix we updated. Our version of the function use an environment variable PLUGIN_SPEC_DIR in the specs.
| github.com/Microsoft/go-winio v0.6.2 | ||
| github.com/Scalingo/go-handlers v1.8.2 | ||
| github.com/Scalingo/go-utils/logger v1.4.0 | ||
| github.com/coreos/go-systemd/v22 v22.5.0 | ||
| github.com/docker/docker v23.0.8+incompatible |
There was a problem hiding this comment.
I'll update this dependency in a dedicated PR as it requires multiple new major versions (#56).
| @@ -1,50 +1,32 @@ | |||
| module github.com/Scalingo/go-plugins-helpers | |||
|
|
|||
| go 1.20 | |||
| go 1.23.5 | |||
There was a problem hiding this comment.
This is the latest version installed on our servers.
EtienneM
force-pushed
the
deps/go_dependencies
branch
from
483bb95 to
41f69b8
Compare
… rather than upstream one
EtienneM
force-pushed
the
deps/go_dependencies
branch
from
41f69b8 to
b418de2
Compare
SCedricThomas
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also removed the CodeShip CI as we can now use GitHub Actions here.
Related to STORY-270