-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(readme): use a PR to bump a version #83
Conversation
hub is deprecated
gh
rather than hub
git push --tags | ||
gh release create v5.0.7 | ||
git commit -m "Bump v${version}" | ||
git push --set-upstream origin release/${version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is it a required command? I don't remember doing this one before using gh pr create ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's indeed not mandatory. gh pr create
will do it if needed. I wanted it to be explicitly done in this procedure. That's how we documented it in other open source projects.
Once the pull request merged, you can tag the new release. | ||
|
||
```sh | ||
git tag v${version} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: is it something that we can automate? Using GitHub Actions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. At least it's not how we do it on other open source projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with your answers, thanks! 🙏
LGTM 🚀
No description provided.