Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): use a PR to bump a version #83

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Oct 17, 2023

No description provided.

@EtienneM EtienneM self-assigned this Oct 17, 2023
@EtienneM EtienneM requested a review from ipfaze October 17, 2023 15:27
@EtienneM EtienneM removed the request for review from ipfaze October 17, 2023 15:28
@EtienneM EtienneM changed the title docs(readme): use gh rather than hub docs(readme): use a PR to bump a version Oct 17, 2023
@EtienneM EtienneM requested a review from ipfaze October 17, 2023 15:30
git push --tags
gh release create v5.0.7
git commit -m "Bump v${version}"
git push --set-upstream origin release/${version}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is it a required command? I don't remember doing this one before using gh pr create ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's indeed not mandatory. gh pr create will do it if needed. I wanted it to be explicitly done in this procedure. That's how we documented it in other open source projects.

Once the pull request merged, you can tag the new release.

```sh
git tag v${version}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: is it something that we can automate? Using GitHub Actions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. At least it's not how we do it on other open source projects.

@EtienneM EtienneM requested a review from ipfaze October 17, 2023 15:49
Copy link

@ipfaze ipfaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your answers, thanks! 🙏
LGTM 🚀

@EtienneM EtienneM merged commit f6a97fa into master Oct 17, 2023
2 checks passed
@EtienneM EtienneM deleted the docs/readme/use_gh branch October 17, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants