Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): add changelog entry due to cli release #1938

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

ipfaze
Copy link
Contributor

@ipfaze ipfaze commented Feb 6, 2023

fix #1937

@ipfaze ipfaze self-assigned this Feb 6, 2023
@ipfaze ipfaze marked this pull request as ready for review February 6, 2023 11:53

### Changelog

* chore(deps): upgrade github.com/Scalingo/go-scalingo/v6.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a CLI release with such a limited changelog? Is it really useful to release a new version for the CLI? Moreover I expect the changelog to be more understandable by customers. Maybe this upgrade adds a useful feature for our customers?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency upgrade allows the CLI to have a better interpretation of the new implemented 429 too many requests errors. Maybe we can wait for the next feature to be merged for the CLI Scalingo/cli#882 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that's the only change I would release only a patch version of the CLI and the changelog would be something like:

* chore(deps): better management of "429 Too Many Requests" errors (upgrade github.com/Scalingo/go-scalingo/v6.2.0)

@@ -0,0 +1,15 @@
---
modified_at: 2023-02-06 16:00:00
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the date here and in the filename before merging so that it matches the date of release

@ipfaze ipfaze merged commit b20b838 into master Feb 10, 2023
@ipfaze ipfaze deleted the feat/1937/add_changelog_entry branch February 10, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add changelog entry due to changes on go-scalingo project
3 participants