Add maintenance listing #982
Conversation
|
|
|
Waiting for go-scalingo release |
There was a problem hiding this comment.
Could you please rebase on master?
I've suggested the change you probably need to do after the rebase.
Due to this PR: #983
cmd/maintenance.go
Outdated
| PerPage: c.Int("per-page"), | ||
| }) | ||
| if err != nil { | ||
| errorQuitWithHelpMessage(err, c, "database-maintenance-list") |
There was a problem hiding this comment.
I don't think that we want to show help message here.
E.g. in case of error when calling DatabaseListMaintenance, just print the error message should be enough
Co-authored-by: Pierre Curzola <[email protected]>
Co-authored-by: Pierre Curzola <[email protected]>
Co-authored-by: Pierre Curzola <[email protected]>
Co-authored-by: Pierre Curzola <[email protected]>
Co-authored-by: Pierre Curzola <[email protected]>
Co-authored-by: Pierre Curzola <[email protected]>
curzolapierre
force-pushed
the
feat/968/maintenance-listing
branch
from
8b60c1a
to
3dd4cb2
Compare
db/maintenance/list.go
Outdated
| ) | ||
|
|
||
| func List(ctx context.Context, app string, addonName string, paginationOpts scalingo.PaginationOpts) error { | ||
| caser := cases.Title(language.English) |
There was a problem hiding this comment.
Out of curiosity why are you using cases?
There was a problem hiding this comment.
Because strings.Title is deprecated: https://stackoverflow.com/questions/71620717/in-go-1-18-strings-title-is-deprecated-what-to-use-now-and-how
db/maintenance/list.go
Outdated
| caser := cases.Title(language.English) | ||
| c, err := config.ScalingoClient(ctx) | ||
| if err != nil { | ||
| return errgo.Notef(err, "get Scalingo client") |
There was a problem hiding this comment.
We should use Wrap now, according to our doc
db/maintenance/list.go
Outdated
|
|
||
| response, err := c.DatabaseListMaintenance(ctx, app, addonName, paginationOpts) | ||
| if err != nil { | ||
| return errgo.Notef(err, "list the database maintenance") |
There was a problem hiding this comment.
Same as above
| return errgo.Notef(err, "list the database maintenance") | |
| return errgo.Wrap(err, "list the database maintenance") |
db/maintenance/list.go
Outdated
| caser.String(string(maintenance.Type)), | ||
| startedAt, | ||
| endedAt, | ||
| caser.String(string(maintenance.Status)), |
There was a problem hiding this comment.
I didn't know the Title method, thanks for sharing 👍
But I don't think that we want to format these fields (i.e. Type, Status). Becuase IMO they should be formatted like they are in platform side in case of issue in user side. That would simplify our investigation, WDYT?
There was a problem hiding this comment.
I respected the user story, but you may be right here: https://github.com/Scalingo/project-items/issues/285
fix #968