Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(term): use os.Stat to get TTY information #974

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(term): use os.Stat to get TTY information #974

merged 2 commits into from
Jun 27, 2023

Conversation

curzolapierre
Copy link
Member

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

Fix #857

@curzolapierre curzolapierre marked this pull request as ready for review June 16, 2023 15:44
EtienneM
EtienneM reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions, otherwise if it works LGTM :)

CHANGELOG.md Outdated Show resolved Hide resolved
term/term_unix.go Outdated Show resolved Hide resolved
@EtienneM EtienneM changed the title Fix/857/remove go termutil fix(term): use os.Stat to get TTY information Jun 21, 2023
@curzolapierre curzolapierre merged commit 89c1162 into master Jun 27, 2023
@curzolapierre curzolapierre deleted the fix/857/remove_go-termutil branch June 27, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace github.com/andrew-d/go-termutil with a maintained lib
2 participants
@curzolapierre @EtienneM