Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(install.sh): change default target directory for Apple Silicon #954

Merged
merged 1 commit into from
May 26, 2023

Conversation

SCKevinO
Copy link
Contributor

Fix #611

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@SCKevinO SCKevinO requested a review from EtienneM May 26, 2023 10:44
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@SCKevinO SCKevinO merged commit 3d4d021 into master May 26, 2023
@SCKevinO SCKevinO deleted the fix/611/change-default-directory-for-mac branch May 26, 2023 12:41
@josephpage
Copy link
Contributor

Hello, sorry I'm only reading the PR now, but I'm wondering about using a folder that only exists when Homebrew is installed for an install script that's going to be used by those who don't usually use Homebrew and on whom it probably won't be installed. Or maybe I'm missing something and I'm sorry to bother you.

@SCKevinO
Copy link
Contributor Author

SCKevinO commented Jun 6, 2023

Hello, Homebrew is pretty common for developers on mac, it seemed like a good fit for a default value and the install script will create the folder if it doesn't exist already. In that case, the problem will be that the folder is not in the PATH.
If you want to change the install folder location, you can do so with the -i option.

@josephpage
Copy link
Contributor

Thanks for the reply, I understand your reasoning better.
Installing a binary in a directory managed by Homebrew could lead to an error during a future installation with Homebrew. That's my only concern.

In fact, Homebrew is so popular on the Mac that most tools now only offer installation with Homebrew or with an nerdy alternative method for those who want full control : a binary to download and move yourself. For example:

The cleanest solution might even be to deprecate this install script for Macs in favor of the Homebrew formula.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installer should use a different default directory on macOS + arm64 (Apple Silicon)
3 participants