feat: handling word answers as user inputs for install script #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCedricThomas
force-pushed
the
feat/929/handle-answers-with-multiple-letters
branch
from
d60c2d2
to
656ed9b
Compare
yohann-bacha
reviewed
May 9, 2023
| @@ -27,6 +27,18 @@ main() { | |||
| fi | |||
| } | |||
|
|
|||
| ask() { | |||
There was a problem hiding this comment.
praise: Nice refacto 👍
yohann-bacha
suggested changes
May 9, 2023
CHANGELOG.md
Outdated
| @@ -8,6 +8,7 @@ | |||
| * chore(deps): replace `github.com/ScaleFT/sshkeys` with `golang.org/x/crypto/ssh` | |||
| * fix(completion): fix zsh shebang reference | |||
| * feat(integration-link): add --follow arg to manual-deploy command | |||
| * feat(install.sh): handle answers with multiple letters | |||
There was a problem hiding this comment.
issue: i think the name of what we're doing is wrong. we're not handling "multiple letters", we become case insensitive
There was a problem hiding this comment.
we are handling yes and no too
There was a problem hiding this comment.
Ok, so what do you think about this sentence? I find it more accurate
Suggested change
| * feat(install.sh): handle answers with multiple letters | |
| * feat(install.sh): handling word answers as user inputs for install script |
yohann-bacha
changed the title
yohann-bacha
changed the title
EtienneM
approved these changes
May 9, 2023
dists/install.sh
Outdated
Comment on lines
152
to
154
| if ! ask "Do you want to replace it with version ${new_version}?" ; then | ||
| status "Aborting...\n" | ||
| exit -1 |
There was a problem hiding this comment.
it seems we have a two spaces indentation in this file
Suggested change
| if ! ask "Do you want to replace it with version ${new_version}?" ; then | |
| status "Aborting...\n" | |
| exit -1 | |
| if ! ask "Do you want to replace it with version ${new_version}?" ; then | |
| status "Aborting...\n" | |
| exit -1 |
yohann-bacha
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #929