Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integration-link): add --follow arg to manual-deploy command #936

Merged
merged 2 commits into from
Apr 20, 2023
Merged

feat(integration-link): add --follow arg to manual-deploy command #936

merged 2 commits into from
Apr 20, 2023

Conversation

gnuletik
Copy link
Contributor

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

Depends on Scalingo/go-scalingo#332

@EtienneM EtienneM self-requested a review April 18, 2023 08:18
@gnuletik gnuletik mentioned this pull request Apr 18, 2023
Merged
1 task
@gnuletik
Copy link
Contributor Author

I rebased my fork with github.com/Scalingo/go-scalingo/[email protected] @EtienneM

@gnuletik
Copy link
Contributor Author

@EtienneM Let me know if anything is blocking this. Thanks!

EtienneM
EtienneM requested changes Apr 20, 2023
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't took the time earlier to review this PR

cmd/integration_link.go Outdated Show resolved Hide resolved
integrationlink/manual_deploy.go Outdated Show resolved Hide resolved
@EtienneM EtienneM merged commit ef7bc48 into Scalingo:master Apr 20, 2023
@gnuletik
Copy link
Contributor Author

No worries! Awesome! Thanks for the merge 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gnuletik @EtienneM