Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(consent) Add consent for more commands #932

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(consent) Add consent for more commands #932

merged 1 commit into from
Apr 12, 2023

Conversation

johnsudaar
Copy link
Contributor

Fix #931

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@johnsudaar johnsudaar self-assigned this Apr 4, 2023
@johnsudaar johnsudaar requested a review from Soulou April 4, 2023 17:42
EtienneM
EtienneM reviewed Apr 5, 2023
View reviewed changes
Copy link
Member

@EtienneM EtienneM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of checking the consent for an allow-list of commands, shouldn't we check it for all commands by default and define a list of commands in which we don't need to check for the consent?

@johnsudaar
Copy link
Contributor Author

It could be an idea but it's not that easy since in our generic command wrapper we have not yet run the current app detector nor do we know if we should. We might at term refactor to have generic app commands but i did not want to make such a refactor.

@johnsudaar johnsudaar requested a review from EtienneM April 5, 2023 08:12
@johnsudaar johnsudaar merged commit 90f1a99 into master Apr 12, 2023
@johnsudaar johnsudaar deleted the fix/931/consent_for_modifications branch April 12, 2023 08:15
@yohann-bacha yohann-bacha mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneM EtienneM EtienneM approved these changes

@Soulou Soulou Awaiting requested review from Soulou

Assignees

@johnsudaar johnsudaar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Consent] Add consent for more commands
3 participants
@johnsudaar @EtienneM @john-scalingo