Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integration-link): no error when --auto-deploy and no branch specified #790

Conversation

QuentinEscudierScalingo
Copy link
Contributor

Fix the problem that did not display the error in the specific case where the auto deploy flag is activated but no branch to deploy is specified.

In addition, all errors are now displayed instead of being skipped.

$ scalingo -a escudierq-test integration-link-create --auto-deploy https://github.com/QuentinEscudierScalingo/sample-go-martini
 !     An error occurred:
       fail to create the repo link: fail to create the SCM repo link: * auto_deploy_enabled → branch can't be blank

Fixes #765

…ified

Fix the problem that did not display the error in the specific case where the auto deploy flag is activated but no branch to deploy is specified.Fixes #765
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinEscudierScalingo QuentinEscudierScalingo merged commit 9fd107a into master Sep 12, 2022
@QuentinEscudierScalingo QuentinEscudierScalingo deleted the fix/765/integration-link-create_no_error_when_auto_deploy branch September 12, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Integration Link] 500 errors doesn't display any message for integration-link-create
2 participants