-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows/publish): golangci-lint #758
Conversation
d1a17e5
to
2129b41
Compare
7010936
to
85e9d73
Compare
85e9d73
to
308e12e
Compare
308e12e
to
8f622fc
Compare
8f622fc
to
2b4f74b
Compare
34d2737
to
99000ca
Compare
da89c1f
to
f51122b
Compare
f51122b
to
ba8aba8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it's LGTM
However I've small questions
Note for later, we could also separate the linter-pull-request
and linter-master
jobs by another trigger. Here, we use on: [push]
for both, we may want to use on: [pull-request]
in the future to simplify configuration.
With this PR being merged, I removed CodeShip from this project. |
linter-*
andtests
jobs are executed in parallel. In case of success, therelease
step is executed.I tested to introduce a linter offense to ensure that it indeed fails in case of error, and the test was successful.