feat(workflows/publish): golangci-lint #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtienneM
force-pushed
the
fix/golangci-lint
branch
9 times, most recently
from
d1a17e5
to
2129b41
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
4 times, most recently
from
7010936
to
85e9d73
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
from
85e9d73
to
308e12e
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
from
308e12e
to
8f622fc
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
from
8f622fc
to
2b4f74b
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
10 times, most recently
from
34d2737
to
99000ca
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
16 times, most recently
from
da89c1f
to
f51122b
Compare
EtienneM
force-pushed
the
fix/golangci-lint
branch
from
f51122b
to
ba8aba8
Compare
curzolapierre
requested changes
Feb 14, 2024
There was a problem hiding this comment.
Overall it's LGTM
However I've small questions
Note for later, we could also separate the linter-pull-request and linter-master jobs by another trigger. Here, we use on: [push] for both, we may want to use on: [pull-request] in the future to simplify configuration.
curzolapierre
approved these changes
Feb 14, 2024
|
With this PR being merged, I removed CodeShip from this project. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linter-*andtestsjobs are executed in parallel. In case of success, thereleasestep is executed.I tested to introduce a linter offense to ensure that it indeed fails in case of error, and the test was successful.