Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows/publish): golangci-lint #758

Merged
merged 8 commits into from
Feb 14, 2024
Merged

feat(workflows/publish): golangci-lint #758

merged 8 commits into from
Feb 14, 2024

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Aug 3, 2022

linter-* and tests jobs are executed in parallel. In case of success, the release step is executed.

I tested to introduce a linter offense to ensure that it indeed fails in case of error, and the test was successful.

@EtienneM EtienneM force-pushed the fix/golangci-lint branch 9 times, most recently from d1a17e5 to 2129b41 Compare August 3, 2022 14:59
@EtienneM EtienneM self-assigned this Aug 3, 2022
@EtienneM EtienneM force-pushed the fix/golangci-lint branch 4 times, most recently from 7010936 to 85e9d73 Compare November 18, 2022 10:52
@EtienneM EtienneM force-pushed the fix/golangci-lint branch 10 times, most recently from 34d2737 to 99000ca Compare February 13, 2024 13:27
@EtienneM EtienneM force-pushed the fix/golangci-lint branch 16 times, most recently from da89c1f to f51122b Compare February 13, 2024 16:36
@EtienneM EtienneM marked this pull request as ready for review February 13, 2024 16:37
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's LGTM

However I've small questions

Note for later, we could also separate the linter-pull-request and linter-master jobs by another trigger. Here, we use on: [push] for both, we may want to use on: [pull-request] in the future to simplify configuration.

.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
@EtienneM EtienneM merged commit 8e0b753 into master Feb 14, 2024
7 checks passed
@EtienneM EtienneM deleted the fix/golangci-lint branch February 14, 2024 11:16
@EtienneM
Copy link
Member Author

With this PR being merged, I removed CodeShip from this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants