Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display region name in migration example commands #540

Merged
merged 3 commits into from
Mar 30, 2020
Merged

Display region name in migration example commands #540

merged 3 commits into from
Mar 30, 2020

Conversation

Soulou
Copy link
Member

@Soulou Soulou commented Mar 27, 2020

Fixes #539

@Soulou Soulou requested a review from johnsudaar March 27, 2020 20:22
johnsudaar
johnsudaar reviewed Mar 30, 2020
View reviewed changes
Copy link
Contributor

@johnsudaar johnsudaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your first commit (upgrade deps) was already done in master so you can remove it and rebase needed.

@Soulou
Copy link
Member Author

Soulou commented Mar 30, 2020

Done

@Soulou Soulou requested a review from johnsudaar March 30, 2020 08:58
@johnsudaar johnsudaar merged commit 7c31734 into master Mar 30, 2020
@johnsudaar johnsudaar deleted the fix/539/region-name-migration branch March 30, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsudaar johnsudaar Awaiting requested review from johnsudaar

Assignees
No one assigned
Labels
reviewable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Migration] Region should be displayed in command examples
2 participants
@Soulou @johnsudaar