Fix: do not fail on short connections #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #516 * Do not reuse ssh.Signer, the connection to ssh agent might be broken * Do not retry the connection if the server closed the connection * Add --bind to db-tunnel to bind a custom command. This is helpful for docker setups where listening on localhost wont make it available on the docker0 interface
Soulou
reviewed
Jan 9, 2020
| @@ -198,6 +207,14 @@ func handleConnToTunnel(sshClient *ssh.Client, dbUrl *url.URL, sock net.Conn, er | |||
| fmt.Printf("End of connection [%d]\n", connID) | |||
| // Connection timeout | |||
| if err != nil && strings.Contains(err.Error(), "use of closed network") { | |||
|
|
|||
| // If the connection has been closed by the CLIENT, we must stop here and return a nil error | |||
| // If the connection has been closed by the SERVER, we must return a errTimeout and retry the connection | |||
There was a problem hiding this comment.
Isn't it legitimate that the server closes the connection sometimes?
There was a problem hiding this comment.
Not on this connection, if the server closed the conneciton, it will break the conneciton at line 191. Here it's the ssh conneciton that broke.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #516