-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Let's Encrypt certificate status #410
Conversation
9f20d86
to
3130a7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if i like the current implementation. It seems messy. Shouldn't we add a new column ?
I don't like it either, but I'm not sure a new column is better. How do you se this new column? Naming it |
560ba9f
to
fe1b11a
Compare
Why not yep. |
Maybe the column should be named "TLS". Therefore Let's Encrypt status and Custom certificate status should be merged? BTW we have the same semantic "problem" on the web dashboard. |
fe1b11a
to
700172a
Compare
|
And for custom certificates ? |
The code didn't change for custom certificate so it displays |
Fix #409