-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerts] CRUD #346
[Alerts] CRUD #346
Conversation
If there is a
PS: This is correctly aligned on the terminal |
1a550cd
to
839ec19
Compare
|
fb3e33f
to
4a95f5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this PR changing so many dependencies. only go-scalingo should be updated no?
I might have been a bit aggressive on the dependencies update... ^^ Can you also answer my question in the first comment:
|
I just have a question for this one. How do we give the user a list of metrics he can use? i.e.
p95_response_time
,rpm_per_container
...Should we add a endpoint which list the metrics as I suggested in https://github.com/Scalingo/api/issues/1036?
Fix #345