Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerts] CRUD #346

Merged
merged 16 commits into from
Apr 6, 2018
Merged

[Alerts] CRUD #346

merged 16 commits into from
Apr 6, 2018

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Mar 22, 2018

I just have a question for this one. How do we give the user a list of metrics he can use? i.e. p95_response_time, rpm_per_container...
Should we add a endpoint which list the metrics as I suggested in https://github.com/Scalingo/api/issues/1036?

Fix #345

@EtienneM
Copy link
Member Author

EtienneM commented Mar 22, 2018

$ scalingo -a biniou alerts
+--------------------------+--------+----------------+-------------------+----------------------+
|            ID            | ACTIVE | CONTAINER TYPE |      METRIC       |        LIMIT         |
+--------------------------+--------+----------------+-------------------+----------------------+
| 5ab1161614dff702a836202b | true   |                | p95_response_time | triggers above 60.00 |
| 5ab1210614dff702a836202f | true   |                | p95_response_time | triggers above 60.00 |
| 5ab8c0d414dff71cafba41a3 | true   | web            | cpu               | triggers above 0.75  |
| 5ab911bf14dff71ce32a8ee5 | true   | web            | cpu               | triggers above 0.75  |
+--------------------------+--------+----------------+-------------------+----------------------+

If there is a RemindEvery set for an alert:

+--------------------------+--------+----------------+-------------------+-----------------------+--------------+
|            ID            | ACTIVE | CONTAINER TYPE |      METRIC       |         LIMIT         | REMIND EVERY |
+--------------------------+--------+----------------+-------------------+-----------------------+--------------+
| 5ab1161614dff702a836202b | true   |                | p95_response_time | triggers above 60.00  |              |
| 5ab1210614dff702a836202f | true   |                | p95_response_time | triggers above 60.00  |              |
| 5ab8c0d414dff71cafba41a3 | true   | web            | cpu               | triggers above 0.75   |              |
| 5ab911bf14dff71ce32a8ee5 | true   | web            | cpu               | triggers above 0.75   |              |
| 5ab91b9d14dff71ce32a8ee9 | true   | web            | rpm_per_container | triggers below 100.00 | 5m30s        |
+--------------------------+--------+----------------+-------------------+-----------------------+--------------+

PS: This is correctly aligned on the terminal

@EtienneM
Copy link
Member Author

$ scalingo -a biniou alerts-disable 5ab113ad14dff702a8362025
-----> Alert disabled
$ scalingo -a biniou alerts-enable 5ab113ad14dff702a8362025
-----> Alert enabled
$ scalingo -a biniou alerts-update 5ab113ad14dff702a8362025 --limit 150 --container-type web
-----> Alert updated
$ scalingo -a biniou alerts-remove 5ab1159a14dff702a836202a
-----> The alert has been deleted

@EtienneM EtienneM self-assigned this Mar 27, 2018
Copy link
Member

@Soulou Soulou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this PR changing so many dependencies. only go-scalingo should be updated no?

@EtienneM
Copy link
Member Author

EtienneM commented Apr 4, 2018

I might have been a bit aggressive on the dependencies update... ^^
I will revert to only update go-scalingo.

Can you also answer my question in the first comment:

I just have a question for this one. How do we give the user a list of metrics he can use? i.e. p95_response_time, rpm_per_container...
Should we add a endpoint which list the metrics as I suggested in https://github.com/Scalingo/api/issues/1036?

@Soulou Soulou merged commit 0288dc2 into master Apr 6, 2018
@EtienneM EtienneM deleted the fix/345/alert_crud branch May 17, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants