[STORY-642] new api endpoint to handle password reset #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssword. This is dependent on the merging / release of the equivalent branch in go-scalingo library.
EtienneM
approved these changes
Jul 5, 2024
db/users/update_password.go
Outdated
Comment on lines
76
to
77
| } | ||
| } else { |
There was a problem hiding this comment.
suggestion: I like returning the function as soon as possible. In this case, you could return here and the else is useless. There is less indentation which makes the code easier to read IMO
Suggested change
| } | |
| } else { | |
| } | |
| fmt.Printf("User \"%s\" password updated.\n", databaseUser.Name) | |
| return nil | |
| } |
There was a problem hiding this comment.
Thanks. I actually misread the original flow. Your suggestion is absolutely correct. Thanks
There was a problem hiding this comment.
Did you ask product about the CLI backward compatibility?
Yes. My question was answered by benjamin in the comments in the [STORY-642] in notion.
It should be (remain) possible to set a user-supplied password using the CLI.
sc-zenokerr
changed the title
EtienneM
approved these changes
Jul 8, 2024
sc-zenokerr
deleted the
fix/story-642/new-api-endpoint-to-handle-password-reset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database user password update uses new API endpoint for generating password.
This is dependent on the merging / release of the equivalent branch in go-scalingo library.
Story 642