Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(one-off): remove usage of Async parameter when starting one-off #1060

Merged
merged 7 commits into from
Aug 20, 2024
Merged

fix(one-off): remove usage of Async parameter when starting one-off #1060

merged 7 commits into from
Aug 20, 2024

Conversation

SCedricThomas
Copy link
Contributor

@SCedricThomas SCedricThomas commented Apr 26, 2024 •
edited
Loading

Related to https://github.com/Scalingo/app-scheduler/issues/886

This PR aims to remove the notion of async containers from the CLI as they are by default async

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@SCedricThomas SCedricThomas self-assigned this Apr 26, 2024
@SCedricThomas SCedricThomas changed the title fix(one-off): remove async one-off fix(one-off): remove async one-off Aug 20, 2024
@SCedricThomas SCedricThomas requested review from ipfaze and removed request for ipfaze August 20, 2024 12:51
ipfaze
ipfaze requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ipfaze ipfaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue(blocking): I'm not sure we removed the async one-off feature here. But we did remove the async params as it is the default behavior.

CHANGELOG.md Show resolved Hide resolved
@SCedricThomas SCedricThomas marked this pull request as ready for review August 20, 2024 14:03
ipfaze
ipfaze approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@ipfaze ipfaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SCedricThomas SCedricThomas merged commit 0a87757 into master Aug 20, 2024
6 checks passed
@SCedricThomas SCedricThomas deleted the fix/remove-async-one-off branch August 20, 2024 15:35
@Soulou Soulou changed the title fix(one-off): remove async one-off fix(one-off): remove usage of Async parameter when starting one-off Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipfaze ipfaze ipfaze approved these changes

Assignees

@SCedricThomas SCedricThomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SCedricThomas @ipfaze