Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORY-443] Add flag --no-letsencrypt when creating a domain #1058

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

leo-scalingo
Copy link
Contributor

@leo-scalingo leo-scalingo commented Apr 19, 2024

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

Add:

scalingo domains-add mydomain.example.com --no-letsencrypt

Copy link

@leo-scalingo leo-scalingo force-pushed the feat/STORY-443/domaine-no-letsencrypt branch from 82e6f52 to f848883 Compare April 19, 2024 14:37
@leo-scalingo
Copy link
Contributor Author

leo-scalingo commented Apr 19, 2024

+-----------------------+---------+-------------+---------------------------+
|        DOMAIN         | TLS/SSL | TLS SUBJECT | LET'S ENCRYPT CERTIFICATE |
+-----------------------+---------+-------------+---------------------------+
| one-off-2.example.com | -       |             | Disabled                  |
| one-off.example.com   | -       |             | Pending DNS               |
+-----------------------+---------+-------------+---------------------------+
+----------------------------------------+--------------------------------+----------------------------+---------------------------+
|                 DOMAIN                 |            TLS/SSL             |        TLS SUBJECT         | LET'S ENCRYPT CERTIFICATE |
+----------------------------------------+--------------------------------+----------------------------+---------------------------+
| mydomain.example.com                   | Valid until 2025-04-09         | /CN=*.mydomain.example.com | Created, Not in used      |         |
|                                        | 23:59:59 +0000 +0000           |                            |                           |
+----------------------------------------+--------------------------------+----------------------------+---------------------------+
+-------------------------+---------------+-----------------+---------------------------+
|         DOMAIN          |    TLS/SSL    |   TLS SUBJECT   | LET'S ENCRYPT CERTIFICATE |
+-------------------------+---------------+-----------------+---------------------------+
| example.com             | Let's Encrypt | /CN=example.com | Created                   |
+-------------------------+---------------+-----------------+---------------------------+

Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a typo and import to fix

CHANGELOG.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
domains/list.go Outdated Show resolved Hide resolved
leo-scalingo and others added 3 commits April 26, 2024 14:35
Co-authored-by: Pierre Curzola <[email protected]>
Co-authored-by: Pierre Curzola <[email protected]>
@leo-scalingo leo-scalingo merged commit 1f21889 into master Apr 26, 2024
6 checks passed
@leo-scalingo leo-scalingo deleted the feat/STORY-443/domaine-no-letsencrypt branch April 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants