fix(users): user feedback messages improvements

[curzolapierre]

- [ ] Add a changelog entry in the section "To Be Released" of CHANGELOG.md

[ipfaze]

issue(blocking): you can avoid a loop here by saving the user in the last for loop:

cli/db/users/update.go

Line 41 in 2b8d414

for _, user := range l {

And then do your check after:

cli/db/users/update.go

Line 47 in 2b8d414

if !userExists {

[ipfaze]

For better readability I suggest:

Suggested change

	var userExists bool
	var userProtected bool
	for _, user := range l {
	if user.Name == username {
	userExists = true
	if user.Protected {
	userProtected = true
	}
	break
	}
	}
	if !userExists {
	return errors.New(ctx, fmt.Sprintf("User \"%s\" does not exist", username))
	}
	if userProtected {
	return errors.New(ctx, fmt.Sprintf("User \"%s\" is protected and cannot be updated", username))
	}
	var user
	for _, u := range l {
	if u.Name == username {
	user = u
	break
	}
	}
	if user == nil {
	return errors.New(ctx, fmt.Sprintf("User \"%s\" does not exist", username))
	}
	if user.Protected {
	return errors.New(ctx, fmt.Sprintf("User \"%s\" is protected", username))
	}

WDYT?

[curzolapierre]

I pushed a suggestion, WDYT?

[ipfaze]

LGTM 👍