feat(cmd): add aliases for database user management #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curzolapierre
force-pushed
the
feat/1030/db_users_management_command_consistency
branch
from
982db6d
to
0e322f7
Compare
cmd/databases.go
Outdated
| @@ -142,6 +142,7 @@ var ( | |||
|
|
|||
| databaseListUsers = cli.Command{ | |||
| Name: "database-list-users", | |||
| Aliases: []string{"database-users-list"}, | |||
There was a problem hiding this comment.
nitpick (non-blocking): as "database-users-" if our wanted prefix, shouldn't it be the name of the command? and the old name the alias
curzolapierre
force-pushed
the
feat/1030/db_users_management_command_consistency
branch
from
0e322f7
to
17840fc
Compare
yohann-bacha
suggested changes
Jan 24, 2024
curzolapierre
force-pushed
the
feat/1030/db_users_management_command_consistency
branch
from
17840fc
to
7c1903c
Compare
curzolapierre
force-pushed
the
feat/1030/db_users_management_command_consistency
branch
from
7c1903c
to
2eecaf8
Compare
curzolapierre
deleted the
feat/1030/db_users_management_command_consistency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030