Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apps): add stack ID in error message #1008

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix(apps): add stack ID in error message #1008

merged 2 commits into from
Sep 20, 2023

Conversation

EtienneM
Copy link
Member

@EtienneM EtienneM commented Sep 18, 2023 •
edited
Loading

While investigating #976, I found this error message incomplete

Didn't do the following as it does not seem really interesting to highlight in the changelog:

  • Add a changelog entry in the section "To Be Released" of CHANGELOG.md

@EtienneM EtienneM self-assigned this Sep 18, 2023
@EtienneM EtienneM marked this pull request as ready for review September 18, 2023 12:24
@EtienneM EtienneM requested review from yohann-bacha and curzolapierre and removed request for yohann-bacha September 18, 2023 12:26
curzolapierre
curzolapierre approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@curzolapierre curzolapierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EtienneM EtienneM merged commit 124f132 into master Sep 20, 2023
5 checks passed
@EtienneM EtienneM deleted the fix/976/apps-info_stack_name branch September 20, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curzolapierre curzolapierre curzolapierre approved these changes

Assignees

@EtienneM EtienneM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EtienneM @curzolapierre