Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency ws to 7.4.6 [security] - autoclosed #180

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 30, 2021

Mend Renovate

This PR contains the following updates:

Package Change
ws 7.4.0 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in [email protected] (websockets/ws@00c425e) and backported to [email protected] (websockets/ws@78c676d) and [email protected] (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: Branch creation - "" in timezone Etc/UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the renovatebot label May 30, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2021

Codecov Report

Merging #180 (6c33c3c) into master (a5cdead) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   81.65%   81.65%           
=======================================
  Files           6        6           
  Lines         109      109           
  Branches       24       24           
=======================================
  Hits           89       89           
  Misses         20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cdead...6c33c3c. Read the comment docs.

@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] chore(deps): update dependency ws to 7.4.6 [security] - autoclosed Jun 1, 2021
@renovate renovate bot closed this Jun 1, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch June 1, 2021 21:58
@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] - autoclosed chore(deps): update dependency ws to 7.4.6 [security] Jun 2, 2021
@renovate renovate bot reopened this Jun 2, 2021
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch June 2, 2021 18:47
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from c3feb56 to 6c33c3c Compare June 2, 2021 18:49
@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] chore(deps): update dependency ws to 7.4.6 [security] - autoclosed Jan 8, 2022
@renovate renovate bot closed this Jan 8, 2022
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch January 8, 2022 21:57
@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] - autoclosed chore(deps): update dependency ws to 7.4.6 [security] Jan 8, 2022
@renovate renovate bot reopened this Jan 8, 2022
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch January 8, 2022 23:13
@renovate renovate bot changed the title chore(deps): update dependency ws to 7.4.6 [security] chore(deps): update dependency ws to 7.4.6 [security] - autoclosed Sep 29, 2022
@renovate renovate bot closed this Sep 29, 2022
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch September 29, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants