Use setvbuf and allocate a heap buffer on file access #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works around the default 1KB buffer that 3DS newlib has, which makes I/O slow. With this "hack" I mean, workaround, load times are reduced to 25% (around 3-4x faster), making the experience enjoyable. Level loading times around around 4-6 seconds (vs ~25s). This is a hack, ideally some intermediate loading method should be added for consoles that do not have enough ram to load the entire datapack but have enough memory to load a significant amount of it (i.e. an LRU buffer cache or something).
|
Please push this fix! 🙏 |
|
Interesting workaround! |
|
After playing a bit more, maybe I should cap the buffer at 512KB or so, or exclude ogg/ogv files. Theres a small 400ms freeze when the audio track changes. |
The audio freeze is mostly due to the asynchronous load not being implemented yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around the default 1KB buffer that 3DS newlib has, which makes I/O slow. With this "hack" I mean, workaround, load times are reduced to 25% (around 3-4x faster), making the experience enjoyable. Level loading times around around 4-6 seconds (vs ~25s).
This is a hack, ideally some intermediate loading method should be added for consoles that do not have enough ram to load the entire datapack but have enough memory to load a significant amount of it (i.e. an LRU buffer cache or something).