Repository navigation
feat: add notification-thumbnail config/cmdline option to allow sending notification with image thumbnail rather than app icon - #583
Merged
RobertMueller2 merged 8 commits intoAug 2, 2026
Conversation
Member
Author
|
The clippy warning happen in main, too. I'll open a separate PR for that. |
RobertMueller2
force-pushed
the
preview_notification
branch
from
July 12, 2026 07:58
9fa08ba to
528630c
Compare
robertwidfen
left a comment
robertwidfen
left a comment
Collaborator
There was a problem hiding this comment.
Works nicely - just two comments below.
Luckily, I've just set up Noctalia, so the thumbnails are showing up nicely.
RobertMueller2
force-pushed
the
preview_notification
branch
from
August 1, 2026 07:58
87d338a to
ef44d5e
Compare
Bunch of places used `!APP_CONFIG.read().disable_notifications()`, this is actually better placed in the `log_result` itself.
RobertMueller2
force-pushed
the
preview_notification
branch
from
August 2, 2026 04:55
d9cf12b to
e17d879
Compare
robertwidfen
reviewed
Aug 2, 2026
robertwidfen
left a comment
robertwidfen
left a comment
Collaborator
There was a problem hiding this comment.
LGTM - just change the enum and update config & README and then merge.
Collaborator
|
Rethinking this just one time more an it should be: |
robertwidfen
reviewed
Aug 2, 2026
robertwidfen
left a comment
robertwidfen
left a comment
Collaborator
There was a problem hiding this comment.
--notification-thumbnail=screenshot
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #426
Also gets rid of redundant
!APP_CONFIG.read().disable_notifications()by placing that one centrally inlog_result.