Skip to content

refactor: optional extra ring around marker - #539

Merged
RobertMueller2 merged 1 commit into
Satty-org:mainfrom
robertwidfen:refactor_smaller_marker
Jun 13, 2026
Merged

RobertMueller2 merged 1 commit into
Satty-org:mainfrom
robertwidfen:refactor_smaller_marker

Conversation

@robertwidfen

Copy link
Copy Markdown
Collaborator

See issue #243.

Make markers smaller and draw additional ring only if Alt is held. Marker is commited at button release and thus stays moveable.

@RobertMueller2

Copy link
Copy Markdown
Member

Code looks good, function looks good.

Just two minor things I noticed:

  • when dragging the marker and pressing any key which is not bound, ring is toggled once
  • when dragging the marker and pressing any key which is a tool shortcut, there's no redraw and the marker remains until next redraw (which might not happen until next tool action). This isn't exclusive to marker though, and perhaps we need to fix it outside of this PR. Not sure if it broke recently, or nobody ever looked close enough :)

@robertwidfen
robertwidfen force-pushed the refactor_smaller_marker branch from 56ecc58 to cd9bfc2 Compare June 12, 2026 23:11
@robertwidfen

robertwidfen commented Jun 12, 2026 •

Copy link
Copy Markdown
Collaborator Author

Thanks for testing 🤗 - indeed the code was odd, I checked for the Alt-modifier where I should check for the keys Alt_L and Alt_R - at a second glance I added a "!" where it did not make sense.

The tool key issue is actually magically fixed in https://github.com/robertwidfen/Satty/tree/feat_generic_key_bindings #450 - first I was not able to reproduce it as I often work on a merge or all branches and the jj absorb fixes. 🙃 But I want to test this a bit more before creating a pull request.

It is still there, had StopPropagation for some minutes in the code, but this also stops tool switching - created #540 for discussion of expected behavior.

See issue Satty-org#243.

Make markers smaller and draw additional ring only if Alt is held.
Marker is commited at button release and thus stays moveable.
@RobertMueller2

Copy link
Copy Markdown
Member

lgtm.

@RobertMueller2
RobertMueller2 merged commit 5a2817f into Satty-org:main Jun 13, 2026
3 checks passed
@robertwidfen
robertwidfen deleted the refactor_smaller_marker branch June 16, 2026 20:00
RobertMueller2 pushed a commit that referenced this pull request Jun 19, 2026
Further improve issue #243 and PR #539.

- use same size for 1-99 - also avoids site jitter due to 
  small differences in text metrics.
- simpler overall size calculation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants