Repository navigation
refactor: optional extra ring around marker - #539
Merged
RobertMueller2 merged 1 commit intoJun 13, 2026
Merged
Conversation
Member
|
Code looks good, function looks good. Just two minor things I noticed:
|
robertwidfen
force-pushed
the
refactor_smaller_marker
branch
from
June 12, 2026 23:11
56ecc58 to
cd9bfc2
Compare
Collaborator
Author
|
Thanks for testing 🤗 - indeed the code was odd, I checked for the Alt-modifier where I should check for the keys Alt_L and Alt_R - at a second glance I added a "!" where it did not make sense.
It is still there, had |
See issue Satty-org#243. Make markers smaller and draw additional ring only if Alt is held. Marker is commited at button release and thus stays moveable.
robertwidfen
force-pushed
the
refactor_smaller_marker
branch
from
June 12, 2026 23:31
cd9bfc2 to
99fb528
Compare
Member
|
lgtm. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #243.
Make markers smaller and draw additional ring only if Alt is held. Marker is commited at button release and thus stays moveable.