Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add(aria): aria labels for share did and color swatch #1952

Merged
merged 4 commits into from
Mar 28, 2024

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented Mar 27, 2024

What this PR does 📖

  • Adding aria labels for color swatch buttons on Settings General
  • Adding aria labels for Share DID modal
  • Fixing aria label for Settings Accessibility screen

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev linter failing Cargo Workflow (linter) failed on this PR labels Mar 27, 2024
@github-actions github-actions bot removed the linter failing Cargo Workflow (linter) failed on this PR label Mar 27, 2024
Copy link
Contributor

github-actions bot commented Mar 28, 2024

UI Automated Test Results Summary for MacOS/Windows

507 tests   464 ✅  3h 4m 29s ⏱️
 44 suites   43 💤
  3 files      0 ❌

Results for commit 061bbb3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 28, 2024

UI Automated Tests execution is complete! You can find the test results report here

@stavares843 stavares843 removed the Missing dev review Still needs to be reviewed by a dev label Mar 28, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 28, 2024
@stavares843 stavares843 merged commit 595dc6e into dev Mar 28, 2024
7 checks passed
@stavares843 stavares843 deleted the luis/aria-update branch March 28, 2024 22:54
@github-actions github-actions bot removed the Don't merge yet DO NOT MERGE label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants