Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): Chat upload rework #1942

Merged
merged 13 commits into from
Mar 26, 2024
Merged

feat(chat): Chat upload rework #1942

merged 13 commits into from
Mar 26, 2024

Conversation

Flemmli97
Copy link
Collaborator

@Flemmli97 Flemmli97 commented Mar 25, 2024 •
edited
Loading

What this PR does 📖

  • Redo how uploads in chats are done:
    • When sending a message with attachment in chat 2 buttons will be added if that upload fails for some reason:
    • A button to delete the attachment. If that pending message has only that attachment left deleting it will delete the pending message
    • A button to resend the attachment. If that message has only that attachment resending it will resend the whole message (attachment + text). Else it will simply resend that attachment as a new message without text

Which issue(s) this PR fixes 🔨

For testing:

One way to have a file fail upload is by reaching the storage limit

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

511 tests   464 ✅  3h 11m 18s ⏱️
 45 suites   47 💤
  3 files      0 ❌

Results for commit 77cfc29.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 26, 2024
@phillsatellite phillsatellite added Waiting for CI Waiting for at least one CI job to complete before merging and removed Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 26, 2024
@dariusc93 dariusc93 added QA Tested QA has tested and approved Ready to Merge This PR is ready to merge and removed Don't merge yet DO NOT MERGE Waiting for CI Waiting for at least one CI job to complete before merging labels Mar 26, 2024
@stavares843 stavares843 removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 26, 2024
@stavares843 stavares843 merged commit f6bfabd into dev Mar 26, 2024
10 checks passed
@stavares843 stavares843 deleted the chat_upload_rework branch March 26, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@stavares843 stavares843 stavares843 approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

task(chats): if message fails, message should clear from chat
4 participants
@Flemmli97 @dariusc93 @stavares843 @phillsatellite