Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(aria): add aria labels for settings and recovery screens #1693

Merged
merged 8 commits into from
Jan 10, 2024
Merged

update(aria): add aria labels for settings and recovery screens #1693

merged 8 commits into from
Jan 10, 2024

Conversation

luisecm
Copy link
Contributor

@luisecm luisecm commented Jan 9, 2024

What this PR does 📖

  • Implement the usage of custom aria labels for settings sections, instead of using a common aria label. This will help to avoid breaking tests any time that new settings sections are added into Uplink
  • Added aria labels for debugger UI elements
  • Added aria labels for recovery seed screens and latest updates on settings (keybinds sections, online status, recovery seed)

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 9, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Jan 9, 2024
@luisecm luisecm added the Draft PR is still a draft and needs more work label Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

325 tests   265 ✅  1h 32m 44s ⏱️
 23 suites   56 💤
  3 files      2 ❌  2 🔥

For more details on these failures and errors, see this check.

Results for commit 5035154.

♻️ This comment has been updated with latest results.

@github-actions github-actions bot added the missing fixing conflict A conflict exists in current PR and needs resolution label Jan 10, 2024
InfamousVague
InfamousVague approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@InfamousVague InfamousVague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@luisecm luisecm removed the Draft PR is still a draft and needs more work label Jan 10, 2024
@stavares843 stavares843 merged commit 61cd515 into dev Jan 10, 2024
9 of 10 checks passed
@stavares843 stavares843 deleted the luis/settings-arias branch January 10, 2024 22:13
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised missing fixing conflict A conflict exists in current PR and needs resolution labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfamousVague InfamousVague InfamousVague approved these changes

@stavares843 stavares843 stavares843 approved these changes

Assignees

@luisecm luisecm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisecm @InfamousVague @stavares843