Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(textarea): add checks for height bug in chat input #1691

Merged
merged 5 commits into from
Jan 11, 2024
Merged

fix(textarea): add checks for height bug in chat input #1691

merged 5 commits into from
Jan 11, 2024

Conversation

Jekrimo
Copy link
Contributor

@Jekrimo Jekrimo commented Jan 9, 2024

What this PR does 📖

  • add style height checks to handle size bug in input textarea. The prob was seemingly coming from the scroll parent div AND the input textarea div which were having similar problems and adding to each other.

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

script.js is a copy of event_listeners.js that somehow got in, no need for it that I know of

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 9, 2024
@phillsatellite phillsatellite added the Waiting for CI Waiting for at least one CI job to complete before merging label Jan 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

485 tests   401 ✅  2h 28m 30s ⏱️
 40 suites   84 💤
  3 files      0 ❌

Results for commit 01ee58a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Jan 9, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Jan 10, 2024
@stavares843 stavares843 merged commit fe90712 into dev Jan 11, 2024
10 checks passed
@stavares843 stavares843 deleted the textarea-height-on-resize branch January 11, 2024 00:36
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 approved these changes

@stavares843 stavares843 stavares843 approved these changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@Jekrimo Jekrimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(chatbar): when resizing while in full sidebar screen chatbar gets huge
5 participants
@Jekrimo @dariusc93 @stavares843 @phillsatellite @luisecm