Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(RecoveryPhrase): Add UI for removing recovery seed from the account #1688

Merged
merged 10 commits into from
Jan 10, 2024

Conversation

InfamousVague
Copy link
Contributor

@InfamousVague InfamousVague commented Jan 8, 2024

What this PR does 📖

Adds the UI for removing/deleting the mnemonic phrase from the account.

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 8, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

UI Automated Test Results Summary for MacOS/Windows

485 tests   401 ✅  2h 29m 5s ⏱️
 40 suites   84 💤
  3 files      0 ❌

Results for commit 7de0dd9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

UI Automated Tests execution is complete! You can find the test results report here

@dariusc93 dariusc93 added the Draft PR is still a draft and needs more work label Jan 9, 2024
@InfamousVague
Copy link
Contributor Author

image image image

@InfamousVague InfamousVague marked this pull request as ready for review January 9, 2024 19:13
@phillsatellite phillsatellite removed the Draft PR is still a draft and needs more work label Jan 9, 2024
@phillsatellite
Copy link
Contributor

@InfamousVague Just wanted to run this by you to see if this is intended

-On a new account, I went to Settings and removed my recovery seed from my account
-I closed out the app and re opened
-When I then went to Settings again my recovery phrase was back in Settings

Screen.Recording.2024-01-09.at.3.25.43.PM.mov

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Jan 9, 2024
@phillsatellite phillsatellite removed the Changes requested When other dev or QA request a change label Jan 9, 2024
@phillsatellite phillsatellite added Waiting for CI Waiting for at least one CI job to complete before merging QA Tested QA has tested and approved and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Jan 9, 2024
@InfamousVague InfamousVague merged commit f23a636 into dev Jan 10, 2024
4 checks passed
@InfamousVague InfamousVague deleted the recovery-three branch January 10, 2024 16:35
@github-actions github-actions bot removed the QA Tested QA has tested and approved label Jan 10, 2024
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants